yiguolei commented on code in PR #39497:
URL: https://github.com/apache/doris/pull/39497#discussion_r1721618955
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -64,11 +63,14 @@ class AcceptNullPredicate : public ColumnPredicate {
void evaluate_and(const vectorized::IColumn& column, const uint16_t* sel,
uint16_t size,
bool* flags) const override {
if (column.has_null()) {
+ std::vector<uint8_t> original_flags(size);
+ memcpy(original_flags.data(), flags, size);
+
const auto& nullable_col = assert_cast<const
vectorized::ColumnNullable&>(column);
_nested->evaluate_and(nullable_col.get_nested_column(), sel, size,
flags);
const auto& nullmap = nullable_col.get_null_map_data();
for (uint16_t i = 0; i < size; ++i) {
- flags[i] |= nullmap[sel[i]];
+ flags[i] |= (original_flags[i] && nullmap[sel[i]]);
Review Comment:
我觉得这里不对吧
是不是应该是 flags[sel[i]] |= (original_flags[sel[i]] && nullmap[sel[i]]);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
