eldenmoon commented on code in PR #39022: URL: https://github.com/apache/doris/pull/39022#discussion_r1721162070
########## be/src/vec/columns/column_object.cpp: ########## @@ -1381,34 +1585,72 @@ Status ColumnObject::merge_sparse_to_root_column() { return Status::OK(); } -void ColumnObject::finalize_if_not() { - if (!is_finalized()) { - finalize(); - } -} - -void ColumnObject::finalize(bool ignore_sparse) { +void ColumnObject::unnest(Subcolumns::NodePtr& entry, Subcolumns& subcolumns) const { + entry->data.finalize(); + auto nested_column = entry->data.get_finalized_column_ptr()->assume_mutable(); + auto* nested_column_nullable = assert_cast<ColumnNullable*>(nested_column.get()); + auto* nested_column_array = + assert_cast<ColumnArray*>(nested_column_nullable->get_nested_column_ptr().get()); Review Comment: it's nested column from nullable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org