eldenmoon commented on code in PR #39022:
URL: https://github.com/apache/doris/pull/39022#discussion_r1721148798
##########
be/src/vec/columns/column_object.h:
##########
@@ -125,27 +131,33 @@ class ColumnObject final : public COWHelper<IColumn,
ColumnObject> {
void get(size_t n, Field& res) const;
- /// Checks the consistency of column's parts stored in @data.
- void checkTypes() const;
-
/// Inserts a field, which scalars can be arbitrary, but number of
/// dimensions should be consistent with current common type.
/// throws InvalidArgument when meet conflict types
void insert(Field field);
void insert(Field field, FieldInfo info);
- void insertDefault();
+ void insert_default();
+
+ void insert_many_defaults(size_t length);
- void insertManyDefaults(size_t length);
+ void insert_range_from(const Subcolumn& src, size_t start, size_t
length);
- void insertRangeFrom(const Subcolumn& src, size_t start, size_t
length);
+ /// Recreates subcolumn with default scalar values and keeps sizes of
arrays.
+ /// Used to create columns of type Nested with consistent array sizes.
+ Subcolumn recreate_with_default_values(const FieldInfo& field_info)
const;
void pop_back(size_t n);
+ Subcolumn cut(size_t start, size_t length) const;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
