eldenmoon commented on code in PR #39022:
URL: https://github.com/apache/doris/pull/39022#discussion_r1721173331
##########
be/src/olap/rowset/segment_v2/hierarchical_data_reader.cpp:
##########
@@ -51,12 +52,15 @@ Status
HierarchicalDataReader::create(std::unique_ptr<ColumnIterator>* reader,
// Eg. {"a" : "b" : {"c" : 1}}, access the `a.b` path and merge with root
path so that
// we could make sure the data could be fully merged, since some column
may not be extracted but remains in root
// like {"a" : "b" : {"e" : 1.1}} in jsonb format
- ColumnIterator* it;
- RETURN_IF_ERROR(root->data.reader->new_iterator(&it));
- stream_iter->set_root(std::make_unique<StreamReader>(
- root->data.file_column_type->create_column(),
std::unique_ptr<ColumnIterator>(it),
- root->data.file_column_type));
+ if (read_type == ReadType::MERGE_SPARSE) {
Review Comment:
yes, it may result performance issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
