yiguolei commented on code in PR #38168: URL: https://github.com/apache/doris/pull/38168#discussion_r1685697259
########## be/src/runtime/memory/thread_mem_tracker_mgr.h: ########## @@ -291,6 +291,9 @@ inline bool ThreadMemTrackerMgr::try_reserve(int64_t size) { _limiter_tracker_raw->release(size); // rollback return false; } + if (_limiter_tracker_raw->wg_refresh_interval_memory_growth != nullptr) { Review Comment: 我们最终还是要在thread context 中放一个workload group的weak ptr。比如我们做IO 隔离,我们会在page io 那个地方就要获取当前在哪个wg 里,获得wg 相关的io limiter,此时也得依赖这个获得。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org