yiguolei commented on code in PR #38168:
URL: https://github.com/apache/doris/pull/38168#discussion_r1685308773


##########
be/src/runtime/workload_group/workload_group.h:
##########
@@ -186,7 +167,7 @@ class WorkloadGroup : public 
std::enable_shared_from_this<WorkloadGroup> {
     // new query can not submit
     // waiting running query to be cancelled or finish
     bool _is_shutdown = false;
-    std::unordered_map<TUniqueId, std::weak_ptr<QueryContext>> _query_ctxs;

Review Comment:
   这个不要改,我们需要在wg 中保存query ctx的weak ptr。
   因为我们总是需要两条路径,通过queryctx 找到 wg;从wg 找到所有的query。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to