yiguolei commented on code in PR #38168:
URL: https://github.com/apache/doris/pull/38168#discussion_r1685696855
##########
be/src/runtime/memory/mem_tracker_limiter.h:
##########
@@ -202,6 +202,18 @@ class MemTrackerLimiter final : public MemTracker {
return querytid;
}
+ void set_weighted_memory(int64_t weighted_limit, double weighted_ratio) {
+ std::lock_guard<std::mutex> l(_weighted_mem_lock);
+ _weighted_limit = weighted_limit;
Review Comment:
我感觉这两个变量还是放到query ctx 中比较好，
memtracker 只要把memory track 准就可以了，不要把这些预估的计算也放到memtracker 里。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
