yujun777 commented on code in PR #35970:
URL: https://github.com/apache/doris/pull/35970#discussion_r1641600932
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1470,6 +1475,40 @@ private void checkReplicaContinuousVersionSucc(long
tabletId, Replica replica, b
}
}
+ private void checkReplicaContinuousVersionSucc(List<Long> subTxnIds, long
alterWaterschedTxnId, long tabletId,
+ Replica replica, long minReplicaVersion, long maxReplicaVersion,
+ List<PublishVersionTask> replicaPublishTasks, Set<Long>
errorReplicaIds, List<Replica> tabletSuccReplicas,
+ List<Replica> tabletWriteFailedReplicas, List<Replica>
tabletVersionFailedReplicas) {
+ boolean success = true;
+ for (int i = 0; i < subTxnIds.size(); i++) {
+ PublishVersionTask task = replicaPublishTasks.get(i);
+ success = (task != null && task.isFinished() &&
task.getSuccTablets().containsKey(tabletId)) || (
+ replica.getState() == Replica.ReplicaState.ALTER &&
(!Config.publish_version_check_alter_replica
+ || subTxnIds.get(i) < alterWaterschedTxnId));
Review Comment:
|| subTxnIds.get(i) < alterWaterschedTxnId || alterWaterschedTxnId == -1L));
// 这个地方漏了 alterWaterschedTxnId == -1L。 因为job 刚开始创建时sc job时， job 的
alterWaterschedTxnId 还是-1， 此时这个导入任务必定还没有导入这个新的tablet， 所以需要忽略它
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
