yujun777 commented on code in PR #35970:
URL: https://github.com/apache/doris/pull/35970#discussion_r1640778197
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1470,6 +1475,43 @@ private void checkReplicaContinuousVersionSucc(long
tabletId, Replica replica, b
}
}
+ private void checkReplicaContinuousVersionSucc(List<Long> subTxnIds, long
alterWaterschedTxnId, long tabletId,
+ Replica replica, long minReplicaVersion, long maxReplicaVersion,
+ List<PublishVersionTask> replicaPublishTasks, Set<Long>
errorReplicaIds, List<Replica> tabletSuccReplicas,
+ List<Replica> tabletWriteFailedReplicas, List<Replica>
tabletVersionFailedReplicas) {
+ boolean success = true;
+ if (replicaPublishTasks.size() != subTxnIds.size()) {
Review Comment:
delete line 1483 ~ 1484
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1470,6 +1475,43 @@ private void checkReplicaContinuousVersionSucc(long
tabletId, Replica replica, b
}
}
+ private void checkReplicaContinuousVersionSucc(List<Long> subTxnIds, long
alterWaterschedTxnId, long tabletId,
Review Comment:
可以重构代码，删除1429行定义的checkReplicaContinuousVersionSucc。只保留这里的函数就可以了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
