yujun777 commented on code in PR #35970:
URL: https://github.com/apache/doris/pull/35970#discussion_r1640781283
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1470,6 +1475,43 @@ private void checkReplicaContinuousVersionSucc(long
tabletId, Replica replica, b
}
}
+ private void checkReplicaContinuousVersionSucc(List<Long> subTxnIds, long
alterWaterschedTxnId, long tabletId,
+ Replica replica, long minReplicaVersion, long maxReplicaVersion,
+ List<PublishVersionTask> replicaPublishTasks, Set<Long>
errorReplicaIds, List<Replica> tabletSuccReplicas,
+ List<Replica> tabletWriteFailedReplicas, List<Replica>
tabletVersionFailedReplicas) {
+ boolean success = true;
+ if (replicaPublishTasks.size() != subTxnIds.size()) {
Review Comment:
把这里1483 ~ 1484 行删了， 没task 不代表它就是失败的。 是否成功要看1487 行的判断。 另外，传进来的subTxnIds 的长度等于
replicaPublishTasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
