seawinde commented on code in PR #34274:
URL: https://github.com/apache/doris/pull/34274#discussion_r1595149911
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewAggregateRule.java:
##########
@@ -284,6 +285,26 @@ protected Plan rewriteQueryByView(MatchMode matchMode,
}
// add project to guarantee group by column ref is slot reference,
// this is necessary because physical createHash will need
slotReference later
+ for (Expression expression : queryChildrenGroupBySet) {
Review Comment:
you are right, this check condition should be `if top group by doest equals
bottom group by, we should add check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
