Z-SWEI commented on code in PR #34274:
URL: https://github.com/apache/doris/pull/34274#discussion_r1595118679
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewAggregateRule.java:
##########
@@ -284,6 +285,26 @@ protected Plan rewriteQueryByView(MatchMode matchMode,
}
// add project to guarantee group by column ref is slot reference,
// this is necessary because physical createHash will need
slotReference later
+ for (Expression expression : queryChildrenGroupBySet) {
Review Comment:
有没有可能queryTopPlanGroupBySet不为空，但是也没有包含全部的groupby字段 这种情况？
比如 `select sum(o_totalprice), a from orders group by o_orderdate, a, b`
这种情况的话`if (!queryGroupByExpressions.isEmpty() &&
queryTopPlanGroupBySet.isEmpty())`是不是筛查不出来
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
