Z-SWEI commented on code in PR #34274:
URL: https://github.com/apache/doris/pull/34274#discussion_r1595114293
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewAggregateRule.java:
##########
@@ -284,6 +285,26 @@ protected Plan rewriteQueryByView(MatchMode matchMode,
}
// add project to guarantee group by column ref is slot reference,
// this is necessary because physical createHash will need
slotReference later
+ for (Expression expression : queryChildrenGroupBySet) {
+ Expression queryGroupShuttledExpr =
ExpressionUtils.shuttleExpressionWithLineage(
+ expression, queryTopPlan,
queryStructInfo.getTableBitSet());
+ AggregateExpressionRewriteContext context = new
AggregateExpressionRewriteContext(true,
+ mvExprToMvScanExprQueryBased, queryTopPlan,
queryStructInfo.getTableBitSet());
+ // group by expression maybe group by a + b, so we need expression
rewriter
+ Expression rewrittenGroupByExpression =
queryGroupShuttledExpr.accept(AGGREGATE_EXPRESSION_REWRITER,
+ context);
+ if (!context.isValid()) {
+ // group expr can not rewrite by view
+ materializationContext.recordFailReason(queryStructInfo,
+ "View dimensions doesn't not cover the query
dimensions in bottom agg ",
+ () -> String.format("mvExprToMvScanExprQueryBased is
%s,\n queryGroupShuttledExpr is %s",
+ mvExprToMvScanExprQueryBased,
queryGroupShuttledExpr));
+ return null;
+ }
+ NamedExpression groupByExpression = rewrittenGroupByExpression
instanceof NamedExpression
+ ? (NamedExpression) rewrittenGroupByExpression : new
Alias(rewrittenGroupByExpression);
+ finalGroupExpressions.add(groupByExpression);
Review Comment:
感觉得留在finalGroupExpressions里边吧。比如像下面这个select语句在改写的时候，logicalProject里边不包含groupby的字段，这个时候不把child里边的logicalAggregate的groupby
o_orderdate留着，那改写成功以后这个groupby不就被丢掉了吗？我理解错了吗
```sql
select sum(o_totalprice) from orders group by o_orderdate
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
