zuochunwei commented on pull request #7558: URL: https://github.com/apache/incubator-doris/pull/7558#issuecomment-1007289882
> I think there is another optimization point for `row_cursor`; When only `string type` is needed, it's clear that only `_long_text_buf` need to be allocated memory, `_variable_buf` won't be used, so in `_alloc_buf()`, allocation for _variable_buf is not necessary; I think the allocation for `_long_text_buf` and `_variable_buf` should be separated; Of course, this optimization can be done later. So I think `_long_text_buf` should not be removed; if all fields are long_text_buf, the _variable_len calculcted by init function will be 0, so memory will not allocated for var -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
