wangbo commented on a change in pull request #7558:
URL: https://github.com/apache/incubator-doris/pull/7558#discussion_r779309215
##########
File path: be/src/olap/row_cursor.h
##########
@@ -36,10 +36,13 @@ class RowCursor {
public:
static const int DEFAULT_TEXT_LENGTH = 128;
- RowCursor();
+ RowCursor() = default;
// 遍历销毁field指针
- ~RowCursor();
+ ~RowCursor() {
+ delete [] _owned_fixed_buf;
+ delete [] _variable_buf;
Review comment:
If _variable_buf holds a ref of an Object such as Slice,can ```delete []
_variable_buf ``` trigger Slice's ?destructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
