zuochunwei commented on a change in pull request #7558:
URL: https://github.com/apache/incubator-doris/pull/7558#discussion_r779322688
##########
File path: be/src/olap/row_cursor.h
##########
@@ -36,10 +36,13 @@ class RowCursor {
public:
static const int DEFAULT_TEXT_LENGTH = 128;
- RowCursor();
+ RowCursor() = default;
// 遍历销毁field指针
- ~RowCursor();
+ ~RowCursor() {
+ delete [] _owned_fixed_buf;
+ delete [] _variable_buf;
Review comment:
no!
because the type of _variable_buf is char*, so delete[] _variable_buf will
just release the memory allocated by corresponding new[]. not matter whatever
the _variable_buf is used for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
