amorynan commented on code in PR #33493:
URL: https://github.com/apache/doris/pull/33493#discussion_r1560370344
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1513,4 +1514,78 @@ Status ColumnObject::sanitize() const {
return Status::OK();
}
+void ColumnObject::Subcolumn::replace(Field field, int row_num) {
+ finalize();
+ Field new_field;
+ if (!field.is_null()) {
+ convert_field_to_type(field, *least_common_type.get(), &new_field);
+ data.back()->replace(new_field, row_num);
+ } else {
+ data.back()->replace(Null(), row_num);
+ }
+}
+
+void ColumnObject::replace_column_data(const IColumn& col, size_t row, size_t
self_row) {
+ DCHECK(size() > self_row);
+ DCHECK(col.size() > row);
Review Comment:
here may be should clear first when self_row == 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
