github-actions[bot] commented on code in PR #33493:
URL: https://github.com/apache/doris/pull/33493#discussion_r1559261187
##########
be/src/olap/tablet_schema.h:
##########
@@ -426,6 +429,22 @@ class TabletSchema {
return str;
}
+ string dump() const {
Review Comment:
warning: method 'dump' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static string dump() {
```
##########
be/src/vec/columns/column_object.h:
##########
@@ -456,13 +460,11 @@ class ColumnObject final : public COWHelper<IColumn,
ColumnObject> {
LOG(FATAL) << "should not call the method in column object";
}
- void replace_column_data(const IColumn&, size_t row, size_t self_row)
override {
- LOG(FATAL) << "should not call the method in column object";
- }
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: method 'is_variable_length' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool is_variable_length() override { return true; }
```
##########
be/src/vec/columns/column_string.h:
##########
@@ -578,6 +578,29 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
}
}
+ void replace(const Field& f, size_t self_row) override {
Review Comment:
warning: method 'replace' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void replace(const Field& f, size_t self_row) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
