github-actions[bot] commented on code in PR #31692:
URL: https://github.com/apache/doris/pull/31692#discussion_r1511333238
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -393,21 +400,23 @@ void ColumnReader::_parse_zone_map(const ZoneMapPB&
zone_map, WrapperField* min_
max_value_container->set_null();
}
}
+ return Status::OK();
}
-void ColumnReader::_parse_zone_map_skip_null(const ZoneMapPB& zone_map,
- WrapperField* min_value_container,
- WrapperField*
max_value_container) const {
+Status ColumnReader::_parse_zone_map_skip_null(const ZoneMapPB& zone_map,
Review Comment:
warning: method '_parse_zone_map_skip_null' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status ColumnReader::_parse_zone_map_skip_null(const ZoneMapPB&
zone_map,
```
be/src/olap/rowset/segment_v2/column_reader.cpp:407:
```diff
- WrapperField*
max_value_container) const {
+ WrapperField*
max_value_container) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
