github-actions[bot] commented on code in PR #31692:
URL: https://github.com/apache/doris/pull/31692#discussion_r1509317576
##########
be/src/olap/calc_delete_bitmap_executor.cpp:
##########
@@ -62,11 +63,12 @@ Status CalcDeleteBitmapToken::wait() {
return _status;
}
-void CalcDeleteBitmapExecutor::init() {
- static_cast<void>(ThreadPoolBuilder("TabletCalcDeleteBitmapThreadPool")
- .set_min_threads(1)
-
.set_max_threads(config::calc_delete_bitmap_max_thread)
- .build(&_thread_pool));
+Status CalcDeleteBitmapExecutor::init() {
Review Comment:
warning: method 'init' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/calc_delete_bitmap_executor.h:78:
```diff
- Status init();
+ static Status init();
```
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -393,21 +401,23 @@
max_value_container->set_null();
}
}
+ return Status::OK();
}
-void ColumnReader::_parse_zone_map_skip_null(const ZoneMapPB& zone_map,
- WrapperField* min_value_container,
- WrapperField*
max_value_container) const {
+Status ColumnReader::_parse_zone_map_skip_null(const ZoneMapPB& zone_map,
Review Comment:
warning: method '_parse_zone_map_skip_null' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status ColumnReader::_parse_zone_map_skip_null(const ZoneMapPB&
zone_map,
```
be/src/olap/rowset/segment_v2/column_reader.cpp:408:
```diff
- WrapperField*
max_value_container) const {
+ WrapperField*
max_value_container) {
```
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -377,12 +385,12 @@ bool
ColumnReader::prune_predicates_by_zone_map(std::vector<ColumnPredicate*>& p
return pruned;
}
-void ColumnReader::_parse_zone_map(const ZoneMapPB& zone_map, WrapperField*
min_value_container,
- WrapperField* max_value_container) const {
+Status ColumnReader::_parse_zone_map(const ZoneMapPB& zone_map, WrapperField*
min_value_container,
+ WrapperField* max_value_container) const {
Review Comment:
warning: method '_parse_zone_map' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status ColumnReader::_parse_zone_map(const ZoneMapPB& zone_map,
WrapperField* min_value_container,
WrapperField* max_value_container) {
```
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -1054,10 +1064,10 @@
return seek_to_ordinal(_page.first_ordinal);
}
-void FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const {
+Status FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const {
Review Comment:
warning: method '_seek_to_pos_in_page' can be made static
[readability-convert-member-functions-to-static]
```suggestion
Status FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) {
```
be/src/olap/rowset/segment_v2/column_reader.h:364:
```diff
- Status _seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const;
+ static Status _seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) ;
```
##########
be/src/runtime/result_buffer_mgr.cpp:
##########
@@ -150,13 +150,13 @@ Status ResultBufferMgr::fetch_arrow_data(const TUniqueId&
finst_id,
return Status::OK();
}
-Status ResultBufferMgr::cancel(const TUniqueId& query_id) {
+void ResultBufferMgr::cancel(const TUniqueId& query_id) {
Review Comment:
warning: method 'cancel' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void ResultBufferMgr::cancel(const TUniqueId& query_id) {
```
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -470,7 +470,7 @@ Status TabletMeta::_save_meta(DataDir* data_dir) {
return status;
}
-Status TabletMeta::serialize(string* meta_binary) {
+void TabletMeta::serialize(string* meta_binary) {
Review Comment:
warning: method 'serialize' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void TabletMeta::serialize(string* meta_binary) {
```
##########
be/src/pipeline/exec/analytic_source_operator.cpp:
##########
@@ -417,15 +415,14 @@ void AnalyticLocalState::_update_order_by_range() {
}
}
-Status AnalyticLocalState::init_result_columns() {
+void AnalyticLocalState::init_result_columns() {
Review Comment:
warning: method 'init_result_columns' can be made const
[readability-make-member-function-const]
```suggestion
void AnalyticLocalState::init_result_columns() const {
```
be/src/pipeline/exec/analytic_source_operator.h:57:
```diff
- void init_result_columns();
+ void init_result_columns() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
