zclllyybb commented on code in PR #31692:
URL: https://github.com/apache/doris/pull/31692#discussion_r1514753238
##########
be/src/io/fs/benchmark/fs_benchmark_tool.cpp:
##########
@@ -115,10 +115,14 @@ int main(int argc, char** argv) {
// init s3 write buffer pool
std::unique_ptr<doris::ThreadPool> s3_file_upload_thread_pool;
- static_cast<void>(doris::ThreadPoolBuilder("S3FileUploadThreadPool")
- .set_min_threads(num_cores)
- .set_max_threads(num_cores)
- .build(&s3_file_upload_thread_pool));
+ doris::Status st = doris::ThreadPoolBuilder("S3FileUploadThreadPool")
+ .set_min_threads(num_cores)
+ .set_max_threads(num_cores)
+ .build(&s3_file_upload_thread_pool);
+ if (!st.ok()) {
+ std::cerr << "init s3 write buffer pool failed" << std::endl;
Review Comment:
change all of them. not only this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
