ByteYue commented on code in PR #30014:
URL: https://github.com/apache/doris/pull/30014#discussion_r1453433419
##########
be/src/service/backend_service.h:
##########
@@ -130,18 +125,11 @@ class BackendService : public BackendServiceIf {
// used for external service, close some context and release resource
related with this context
void close_scanner(TScanCloseResult& result_, const TScanCloseParams&
params) override;
- void get_stream_load_record(TStreamLoadRecordResult& result,
- const int64_t last_stream_record_time)
override;
-
- void clean_trash() override;
-
- void check_storage_format(TCheckStorageFormatResult& result) override;
-
- void ingest_binlog(TIngestBinlogResult& result, const
TIngestBinlogRequest& request) override;
-
- void query_ingest_binlog(TQueryIngestBinlogResult& result,
- const TQueryIngestBinlogRequest& request)
override;
-
+ // TODO(AlexYue): The below cloud backend functions should be implemented
in
+ // CloudBackendService
+
////////////////////////////////////////////////////////////////////////////
+ // begin cloud backend functions
+
////////////////////////////////////////////////////////////////////////////
void pre_cache_async(TPreCacheAsyncResponse& response,
Review Comment:
They will only serve for Cloud-Mode, currently they have to be inherited and
implemented because `BackendServiceIf` is one interface with only pure
functions. These cloud backend functions should be moved to cloud backend
service afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
