github-actions[bot] commented on code in PR #30014:
URL: https://github.com/apache/doris/pull/30014#discussion_r1452999695
##########
be/src/service/internal_service.cpp:
##########
@@ -1150,7 +1158,7 @@ void
PInternalServiceImpl::apply_filter(::google::protobuf::RpcController* contr
}
}
-void PInternalServiceImpl::apply_filterv2(::google::protobuf::RpcController*
controller,
+void PInternalService::apply_filterv2(::google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'apply_filterv2' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::apply_filterv2(::google::protobuf::RpcController* controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1172,7 +1180,7 @@
}
}
-void PInternalServiceImpl::send_data(google::protobuf::RpcController*
controller,
+void PInternalService::send_data(google::protobuf::RpcController* controller,
Review Comment:
warning: method 'send_data' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void PInternalService::send_data(google::protobuf::RpcController*
controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1268,7 +1276,7 @@
}
}
-Status PInternalServiceImpl::_fold_constant_expr(const std::string&
ser_request,
+Status PInternalService::_fold_constant_expr(const std::string& ser_request,
Review Comment:
warning: method '_fold_constant_expr' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status PInternalService::_fold_constant_expr(const std::string&
ser_request,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1947,10 +1955,10 @@
google::protobuf::Closure* done) {
brpc::ClosureGuard closure_guard(done);
VLOG_DEBUG << "receive get tablet versions request: " <<
request->DebugString();
- StorageEngine::instance()->get_tablet_rowset_versions(request, response);
+ _engine.get_tablet_rowset_versions(request, response);
}
-void PInternalServiceImpl::glob(google::protobuf::RpcController* controller,
+void PInternalService::glob(google::protobuf::RpcController* controller,
Review Comment:
warning: method 'glob' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void PInternalService::glob(google::protobuf::RpcController*
controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1253,7 +1261,7 @@
}
}
-void PInternalServiceImpl::fold_constant_expr(google::protobuf::RpcController*
controller,
+void PInternalService::fold_constant_expr(google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'fold_constant_expr' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::fold_constant_expr(google::protobuf::RpcController*
controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1387,7 +1395,7 @@
}
}
-void PInternalServiceImpl::reset_rpc_channel(google::protobuf::RpcController*
controller,
+void PInternalService::reset_rpc_channel(google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'reset_rpc_channel' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::reset_rpc_channel(google::protobuf::RpcController* controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1230,7 +1238,7 @@
}
}
-void PInternalServiceImpl::rollback(google::protobuf::RpcController*
controller,
+void PInternalService::rollback(google::protobuf::RpcController* controller,
Review Comment:
warning: method 'rollback' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void PInternalService::rollback(google::protobuf::RpcController*
controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1298,7 +1306,7 @@
_transmit_block(controller, request, response, done, Status::OK());
}
-void
PInternalServiceImpl::transmit_block_by_http(google::protobuf::RpcController*
controller,
+void PInternalService::transmit_block_by_http(google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'transmit_block_by_http' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::transmit_block_by_http(google::protobuf::RpcController*
controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -2042,7 +2050,7 @@
}
};
-void PInternalServiceImpl::get_wal_queue_size(google::protobuf::RpcController*
controller,
+void PInternalService::get_wal_queue_size(google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'get_wal_queue_size' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::get_wal_queue_size(google::protobuf::RpcController*
controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1426,7 +1434,7 @@
}
}
-void PInternalServiceImpl::hand_shake(google::protobuf::RpcController*
controller,
+void PInternalService::hand_shake(google::protobuf::RpcController* controller,
Review Comment:
warning: method 'hand_shake' can be made static
[readability-convert-member-functions-to-static]
be/src/service/internal_service.h:164:
```diff
- void hand_shake(google::protobuf::RpcController* controller, const
PHandShakeRequest* request,
+ static void hand_shake(google::protobuf::RpcController* controller,
const PHandShakeRequest* request,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1206,7 +1214,7 @@
}
}
-void PInternalServiceImpl::commit(google::protobuf::RpcController* controller,
+void PInternalService::commit(google::protobuf::RpcController* controller,
Review Comment:
warning: method 'commit' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void PInternalService::commit(google::protobuf::RpcController*
controller,
```
##########
be/src/service/internal_service.h:
##########
@@ -18,32 +18,30 @@
#pragma once
#include <gen_cpp/internal_service.pb.h>
Review Comment:
warning: 'gen_cpp/internal_service.pb.h' file not found
[clang-diagnostic-error]
```cpp
#include <gen_cpp/internal_service.pb.h>
^
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1354,7 +1362,7 @@
}
}
-void PInternalServiceImpl::check_rpc_channel(google::protobuf::RpcController*
controller,
+void PInternalService::check_rpc_channel(google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'check_rpc_channel' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::check_rpc_channel(google::protobuf::RpcController* controller,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -1285,7 +1293,7 @@
return st;
}
-void PInternalServiceImpl::transmit_block(google::protobuf::RpcController*
controller,
+void PInternalService::transmit_block(google::protobuf::RpcController*
controller,
Review Comment:
warning: method 'transmit_block' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
PInternalService::transmit_block(google::protobuf::RpcController* controller,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
