platoneko commented on code in PR #30014:
URL: https://github.com/apache/doris/pull/30014#discussion_r1453192282
##########
be/src/service/backend_service.h:
##########
@@ -157,12 +145,45 @@ class BackendService : public BackendServiceIf {
void warm_up_tablets(TWarmUpTabletsResponse& response,
const TWarmUpTabletsRequest& request) override;
-
-private:
+
+
////////////////////////////////////////////////////////////////////////////
+ // end cloud backend functions
+
////////////////////////////////////////////////////////////////////////////
+protected:
Status start_plan_fragment_execution(const TExecPlanFragmentParams&
exec_params);
+
ExecEnv* _exec_env = nullptr;
std::unique_ptr<AgentServer> _agent_server;
std::unique_ptr<ThreadPool> _ingest_binlog_workers;
};
+// `StorageEngine` mixin for `BaseBackendService`
+class BackendService : public BaseBackendService {
Review Comment:
Use final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
