github-actions[bot] commented on code in PR #29560:
URL: https://github.com/apache/doris/pull/29560#discussion_r1443751589
##########
be/src/olap/wal/wal_manager.cpp:
##########
@@ -160,76 +160,50 @@ Status WalManager::_init_wal_dirs_info() {
&_update_wal_dirs_info_thread);
}
-void WalManager::add_wal_status_queue(int64_t table_id, int64_t wal_id,
WalStatus wal_status) {
- std::lock_guard<std::shared_mutex> wrlock(_wal_status_lock);
+void WalManager::add_wal_queue(int64_t table_id, int64_t wal_id) {
+ std::lock_guard<std::shared_mutex> wrlock(_wal_queue_lock);
LOG(INFO) << "add wal queue "
- << ",table_id:" << table_id << ",wal_id:" << wal_id <<
",status:" << wal_status;
- auto it = _wal_status_queues.find(table_id);
- if (it == _wal_status_queues.end()) {
- std::unordered_map<int64_t, WalStatus> tmp_map;
- tmp_map.emplace(wal_id, wal_status);
- _wal_status_queues.emplace(table_id, tmp_map);
+ << ",table_id:" << table_id << ",wal_id:" << wal_id;
+ auto it = _wal_queues.find(table_id);
+ if (it == _wal_queues.end()) {
+ std::set<int64_t> tmp_set;
+ tmp_set.insert(wal_id);
+ _wal_queues.emplace(table_id, tmp_set);
} else {
- it->second.emplace(wal_id, wal_status);
+ it->second.insert(wal_id);
}
}
-Status WalManager::erase_wal_status_queue(int64_t table_id, int64_t wal_id) {
- std::lock_guard<std::shared_mutex> wrlock(_wal_status_lock);
- auto it = _wal_status_queues.find(table_id);
- LOG(INFO) << "remove wal queue "
- << ",table_id:" << table_id << ",wal_id:" << wal_id;
- if (it == _wal_status_queues.end()) {
- return Status::InternalError("table_id " + std::to_string(table_id) +
- " not found in wal status queue");
- } else {
+void WalManager::erase_wal_queue(int64_t table_id, int64_t wal_id) {
+ std::lock_guard<std::shared_mutex> wrlock(_wal_queue_lock);
+ auto it = _wal_queues.find(table_id);
+ if (it != _wal_queues.end()) {
+ LOG(INFO) << "remove wal queue "
+ << ",table_id:" << table_id << ",wal_id:" << wal_id;
it->second.erase(wal_id);
if (it->second.empty()) {
- _wal_status_queues.erase(table_id);
+ _wal_queues.erase(table_id);
}
}
- return Status::OK();
}
-Status WalManager::get_wal_status_queue_size(const PGetWalQueueSizeRequest*
request,
- PGetWalQueueSizeResponse*
response) {
- std::lock_guard<std::shared_mutex> wrlock(_wal_status_lock);
+size_t WalManager::get_wal_queue_size(int64_t table_id) {
Review Comment:
warning: method 'get_wal_queue_size' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/wal/wal_manager.h:73:
```diff
- size_t get_wal_queue_size(int64_t table_id);
+ static size_t get_wal_queue_size(int64_t table_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
