mymeiyi commented on code in PR #29560:
URL: https://github.com/apache/doris/pull/29560#discussion_r1442656728
##########
be/src/olap/wal/wal_manager.h:
##########
@@ -72,25 +66,15 @@ class WalManager {
Status create_wal_path(int64_t db_id, int64_t table_id, int64_t wal_id,
const std::string& label, std::string& base_path);
Status get_wal_path(int64_t wal_id, std::string& wal_path);
- Status delete_wal(int64_t wal_id, size_t block_queue_pre_allocated = 0);
+ Status delete_wal(int64_t table_id, int64_t wal_id, size_t
block_queue_pre_allocated = 0);
+ Status rename_to_tmp_path(const std::string wal, int64_t table_id, int64_t
wal_id);
Status add_recover_wal(int64_t db_id, int64_t table_id, int64_t wal_id,
std::string wal);
- // used for ut
+ void add_wal_queue(int64_t table_id, int64_t wal_id);
+ void erase_wal_queue(int64_t table_id, int64_t wal_id);
+ Status get_wal_queue_size(const PGetWalQueueSizeRequest* request,
Review Comment:
remove it and call `_get_wal_queue_size` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
