mymeiyi commented on code in PR #29560:
URL: https://github.com/apache/doris/pull/29560#discussion_r1442657530
##########
be/src/vec/exec/format/wal/wal_reader.cpp:
##########
@@ -75,24 +80,23 @@ Status WalReader::get_next_block(Block* block, size_t*
read_rows, bool* eof) {
return Status::OK();
}
-void WalReader::string_split(const std::string& str, const std::string& splits,
- std::vector<std::string>& res) {
- if (str == "") return;
- std::string strs = str + splits;
- size_t pos = strs.find(splits);
- int step = splits.size();
- while (pos != strs.npos) {
- std::string temp = strs.substr(0, pos);
- res.push_back(temp);
- strs = strs.substr(pos + step, strs.size());
- pos = strs.find(splits);
- }
-}
-
Status WalReader::get_columns(std::unordered_map<std::string, TypeDescriptor>*
name_to_type,
std::unordered_set<std::string>* missing_cols) {
- RETURN_IF_ERROR(_wal_reader->read_header(_version, _col_ids));
-
RETURN_IF_ERROR(_state->exec_env()->wal_mgr()->get_wal_column_index(_wal_id,
_column_index));
+ uint32_t version = 0;
Review Comment:
the version should be an inner variable of wal_reader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
