wangbo commented on code in PR #28443: URL: https://github.com/apache/doris/pull/28443#discussion_r1429617971
########## fe/fe-core/src/main/java/org/apache/doris/common/publish/WorkloadMoveActionPublisherThread.java: ########## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.common.publish; + +import org.apache.doris.common.ClientPool; +import org.apache.doris.common.ThreadPoolManager; +import org.apache.doris.common.util.Daemon; +import org.apache.doris.system.Backend; +import org.apache.doris.system.SystemInfoService; +import org.apache.doris.thrift.BackendService; +import org.apache.doris.thrift.TNetworkAddress; +import org.apache.doris.thrift.TPublishTopicRequest; +import org.apache.doris.thrift.TTopicInfoType; +import org.apache.doris.thrift.TWorkloadMoveQueryToGroupAction; +import org.apache.doris.thrift.TopicInfo; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import java.util.concurrent.ExecutorService; + +public class WorkloadMoveActionPublisherThread extends Daemon { Review Comment: 独立线程主要考虑是两点，第一个是action的数量不会太多。第二个是，publishworkload group的那个线程比较特殊，那个只能master启动，而action这个是每个fe都要起的。其次线程活跃的间隔也不同，moveaction的间隔肯定是越短越好。当然这里可以考虑的设计是，所有action用一个线程 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
