wangbo commented on code in PR #28443:
URL: https://github.com/apache/doris/pull/28443#discussion_r1427663661


##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/CancelQueryAction.java:
##########
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.resource.workloadschedpolicy;
+
+public class CancelQueryAction implements PolicyAction {
+    @Override
+    public void exec(PolicyQueryInfo queryInfo) {
+        if (queryInfo.context != null) {
+            queryInfo.context.cancelQuery();
+        }
+    }
+
+    public static CancelQueryAction createCancelQueryAction() {

Review Comment:
   那个感觉加的类太多了,这个时候还得是一个if else比较快。而且有了工厂模式也还是得有个根据conditionname去判断取哪个factory的过程



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to