yiguolei commented on code in PR #28443: URL: https://github.com/apache/doris/pull/28443#discussion_r1429572910
########## fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadAction.java: ########## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.resource.workloadschedpolicy; + +import org.apache.doris.common.UserException; + +public interface WorkloadAction { + + void exec(WorkloadQueryInfo queryInfo); + + WorkloadActionType getWorkloadActionType(); + + // NOTE(wb) currently createPolicyAction is also used when replay meta, it better not contains heavy check + static WorkloadAction createWorkloadAction(String actionCmd, String actionCmdArgs) + throws UserException { + if (WorkloadActionType.cancel_query.toString().equals(actionCmd)) { + return WorkloadActionCancelQuery.createWorkloadAction(); + } else if (WorkloadActionType.move_query_to_group.toString().equals(actionCmd)) { Review Comment: 这里不要to string 比较， 要把createWorkloadAction 的第一个参数输入变成 enum，在解析阶段就做，不要把string 带到非常靠后的流程处理。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
