caiconghui commented on code in PR #27943:
URL: https://github.com/apache/doris/pull/27943#discussion_r1415290569
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -384,10 +384,15 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler*
scheduler, ScannerContext
ctx->return_free_block(std::move(block));
} else {
if (!blocks.empty() && blocks.back()->rows() + block->rows() <=
state->batch_size()) {
- status =
vectorized::MutableBlock(blocks.back().get()).merge(*block);
+ auto rows = blocks.back()->rows() + block->rows();
+ vectorized::MutableBlock mutable_block(blocks.back().get());
+ status = mutable_block.merge(*block);
if (!status.ok()) {
break;
}
+ if (!blocks.back().get()->is_valid(rows)) {
Review Comment:
the key point is that we reassign value to block from mutable block, and
where to do check i think are both ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
