github-actions[bot] commented on code in PR #27943:
URL: https://github.com/apache/doris/pull/27943#discussion_r1413482181
##########
be/src/vec/core/block.cpp:
##########
@@ -364,6 +364,16 @@ size_t Block::rows() const {
return 0;
}
+bool Block::is_valid(size_t rows) const {
Review Comment:
warning: method 'is_valid' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/core/block.h:186:
```diff
- bool is_valid(size_t rows) const;
+ static bool is_valid(size_t rows) ;
```
```suggestion
bool Block::is_valid(size_t rows) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
