HappenLee commented on code in PR #27943:
URL: https://github.com/apache/doris/pull/27943#discussion_r1417019704
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -394,7 +394,11 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler*
scheduler, ScannerContext
ctx->return_free_block(std::move(block));
} else {
if (!blocks.empty() && blocks.back()->rows() + block->rows() <=
state->batch_size()) {
-
static_cast<void>(vectorized::MutableBlock(blocks.back().get()).merge(*block));
+ vectorized::MutableBlock mutable_block(blocks.back().get());
+ static_cast<void>(mutable_block.merge(*block));
+ if (!blocks.back().get()->is_valid(mutable_block.rows())) {
Review Comment:
why here need to do check ？
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -394,7 +394,11 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler*
scheduler, ScannerContext
ctx->return_free_block(std::move(block));
} else {
if (!blocks.empty() && blocks.back()->rows() + block->rows() <=
state->batch_size()) {
-
static_cast<void>(vectorized::MutableBlock(blocks.back().get()).merge(*block));
+ vectorized::MutableBlock mutable_block(blocks.back().get());
+ static_cast<void>(mutable_block.merge(*block));
+ if (!blocks.back().get()->is_valid(mutable_block.rows())) {
Review Comment:
why here need to do check ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
