yiguolei commented on code in PR #25919: URL: https://github.com/apache/doris/pull/25919#discussion_r1382516338
########## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java: ########## @@ -716,10 +773,9 @@ public void kill(boolean killConnection) { if (killConnection) { isKilled = true; - if (connectType.equals(ConnectType.MYSQL)) { - // Close channel to break connection with client - getMysqlChannel().close(); - } else if (connectType.equals(ConnectType.ARROW_FLIGHT)) { + // Close channel to break connection with client Review Comment: 直接把kill 这个函数实现到flight 的connect context 中吧 ########## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java: ########## @@ -716,10 +773,9 @@ public void kill(boolean killConnection) { if (killConnection) { isKilled = true; - if (connectType.equals(ConnectType.MYSQL)) { - // Close channel to break connection with client - getMysqlChannel().close(); - } else if (connectType.equals(ConnectType.ARROW_FLIGHT)) { + // Close channel to break connection with client Review Comment: 直接把kill 这个函数实现到flight 的connect context 中吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org