yiguolei commented on code in PR #25919: URL: https://github.com/apache/doris/pull/25919#discussion_r1382516057
########## fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlProto.java: ########## @@ -339,7 +339,7 @@ public static boolean negotiate(ConnectContext context) throws IOException { } Env.getCurrentEnv().changeDb(context, dbFullName); } catch (DdlException e) { - context.getState().setError(e.getMysqlErrorCode(), e.getMessage()); + context.getState().setError(e.getUserErrorCode(), e.getMessage()); Review Comment: 这个user error code 的名字,我觉得先别改,因为我们有很多地方跟mysql 是共享的,所以改了也不一定对,等想好了再改吧。 ########## fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlProto.java: ########## @@ -339,7 +339,7 @@ public static boolean negotiate(ConnectContext context) throws IOException { } Env.getCurrentEnv().changeDb(context, dbFullName); } catch (DdlException e) { - context.getState().setError(e.getMysqlErrorCode(), e.getMessage()); + context.getState().setError(e.getUserErrorCode(), e.getMessage()); Review Comment: 这个user error code 的名字,我觉得先别改,因为我们有很多地方跟mysql 是共享的,所以改了也不一定对,等想好了再改吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org