github-actions[bot] commented on code in PR #25919:
URL: https://github.com/apache/doris/pull/25919#discussion_r1381314888
##########
be/src/runtime/result_buffer_mgr.cpp:
##########
@@ -109,21 +109,21 @@ std::shared_ptr<BufferControlBlock>
ResultBufferMgr::find_control_block(const TU
return std::shared_ptr<BufferControlBlock>();
}
-void ResultBufferMgr::register_row_descriptor(const TUniqueId& query_id,
- const RowDescriptor& row_desc) {
- std::unique_lock<std::shared_mutex> wlock(_row_descriptor_map_lock);
- _row_descriptor_map.insert(std::make_pair(query_id, row_desc));
+void ResultBufferMgr::register_arrow_schema(const TUniqueId& query_id,
+ const
std::shared_ptr<arrow::Schema>& arrow_schema) {
+ std::unique_lock<std::shared_mutex> wlock(_arrow_schema_map_lock);
+ _arrow_schema_map.insert(std::make_pair(query_id, arrow_schema));
}
-RowDescriptor ResultBufferMgr::find_row_descriptor(const TUniqueId& query_id) {
- std::shared_lock<std::shared_mutex> rlock(_row_descriptor_map_lock);
- RowDescriptorMap::iterator iter = _row_descriptor_map.find(query_id);
+std::shared_ptr<arrow::Schema> ResultBufferMgr::find_arrow_schema(const
TUniqueId& query_id) {
Review Comment:
warning: method 'find_arrow_schema' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static std::shared_ptr<arrow::Schema>
ResultBufferMgr::find_arrow_schema(const TUniqueId& query_id) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
