sduzh commented on a change in pull request #5027:
URL: https://github.com/apache/incubator-doris/pull/5027#discussion_r537522911
##########
File path: fe/fe-core/src/main/java/org/apache/doris/system/HeartbeatMgr.java
##########
@@ -282,13 +276,20 @@ public HeartbeatResponse call() {
// heartbeat to self
if (Catalog.getCurrentCatalog().isReady()) {
return new FrontendHbResponse(fe.getNodeName(),
Config.query_port, Config.rpc_port,
-
Catalog.getCurrentCatalog().getReplayedJournalId(), System.currentTimeMillis(),
+ Catalog.getCurrentCatalog().getMaxJournalId(),
System.currentTimeMillis(),
Version.DORIS_BUILD_VERSION + "-" +
Version.DORIS_BUILD_SHORT_HASH);
} else {
return new FrontendHbResponse(fe.getNodeName(), "not
ready");
}
}
+ if (Config.enable_fe_heartbeat_by_thrift) {
+ return getHeartbeatResponseByThrift();
+ } else {
+ return getHeartbeatResponseByHttp();
Review comment:
Is it really necessary to keep the HTTP based codes?
cc @kangkaisen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
