sduzh commented on a change in pull request #5027:
URL: https://github.com/apache/incubator-doris/pull/5027#discussion_r538126855
##########
File path: gensrc/thrift/FrontendService.thrift
##########
@@ -689,4 +708,6 @@ service FrontendService {
TStreamLoadPutResult streamLoadPut(1: TStreamLoadPutRequest request)
Status.TStatus snapshotLoaderReport(1: TSnapshotLoaderReportRequest
request)
-}
+
+ TBootstrapResult ping(1: TFrontendPingFrontendRequest request)
Review comment:
If service is named as `ping`, why not just name the request/response as
`TPingRequest`/`TPingResponse`. I'm just curious about the naming rule of
Doris, it's kind of weird for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
