sduzh commented on a change in pull request #5027:
URL: https://github.com/apache/incubator-doris/pull/5027#discussion_r537503725



##########
File path: gensrc/thrift/FrontendService.thrift
##########
@@ -654,6 +654,25 @@ struct TSnapshotLoaderReportRequest {
     5: optional i32 total_num
 }
 
+enum TFrontendPingFrontendStatusCode {
+   OK = 0,
+   FAILED = 1
+}
+
+struct TFrontendPingFrontendRequest {
+   1: required i32 clusterId

Review comment:
       `required` field should be used very carefully,  reference 
[here](https://diwakergupta.github.io/thrift-missing-guide/#_defining_structs)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to