github-actions[bot] commented on code in PR #24029:
URL: https://github.com/apache/doris/pull/24029#discussion_r1319667983
##########
be/test/olap/delete_handler_test.cpp:
##########
@@ -78,8 +80,10 @@ static void set_up() {
doris::EngineOptions options;
options.store_paths = paths;
- Status s = doris::StorageEngine::open(options, &k_engine);
+ k_engine = std::make_unique<StorageEngine>(options);
+ Status s = k_engine->open();
Review Comment:
warning: variable 's' is not initialized [cppcoreguidelines-init-variables]
```suggestion
Status s = 0 = k_engine->open();
```
##########
be/test/olap/engine_storage_migration_task_test.cpp:
##########
@@ -77,16 +77,19 @@ static void set_up() {
doris::EngineOptions options;
options.store_paths = paths;
- Status s = doris::StorageEngine::open(options, &k_engine);
+ k_engine = std::make_unique<StorageEngine>(options);
+ Status s = k_engine->open();
Review Comment:
warning: variable 's' is not initialized [cppcoreguidelines-init-variables]
```suggestion
Status s = 0 = k_engine->open();
```
##########
be/test/olap/memtable_flush_executor_test.cpp:
##########
@@ -55,13 +55,15 @@ void set_up() {
doris::EngineOptions options;
options.store_paths = paths;
- Status s = doris::StorageEngine::open(options, &k_engine);
+ k_engine = std::make_unique<StorageEngine>(options);
+ Status s = k_engine->open();
Review Comment:
warning: variable 's' is not initialized [cppcoreguidelines-init-variables]
```suggestion
Status s = 0 = k_engine->open();
```
##########
be/test/olap/memtable_memory_limiter_test.cpp:
##########
@@ -85,15 +85,23 @@ class MemTableMemoryLimiterTest : public testing::Test {
doris::EngineOptions options;
options.store_paths = paths;
- Status s = doris::StorageEngine::open(options, &_engine);
+ _engine = std::make_unique<StorageEngine>(options);
+ Status st = _engine->open();
Review Comment:
warning: variable 'st' is not initialized [cppcoreguidelines-init-variables]
```suggestion
Status st = 0 = _engine->open();
```
##########
be/test/runtime/load_stream_test.cpp:
##########
@@ -582,10 +583,10 @@ class LoadStreamMgrTest : public testing::Test {
doris::EngineOptions options;
options.store_paths = paths;
- Status s = doris::StorageEngine::open(options, &k_engine);
+ k_engine = std::make_unique<StorageEngine>(options);
+ Status s = k_engine->open();
Review Comment:
warning: variable 's' is not initialized [cppcoreguidelines-init-variables]
```suggestion
Status s = 0 = k_engine->open();
```
##########
be/test/olap/delta_writer_test.cpp:
##########
@@ -79,17 +79,20 @@ static void set_up() {
doris::EngineOptions options;
options.store_paths = paths;
- Status s = doris::StorageEngine::open(options, &k_engine);
+ k_engine = std::make_unique<StorageEngine>(options);
+ Status s = k_engine->open();
Review Comment:
warning: variable 's' is not initialized [cppcoreguidelines-init-variables]
```suggestion
Status s = 0 = k_engine->open();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
