zhannngchen commented on code in PR #22782:
URL: https://github.com/apache/doris/pull/22782#discussion_r1292908523
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -347,7 +347,10 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
// write including columns
std::vector<vectorized::IOlapColumnDataAccessor*> key_columns;
vectorized::IOlapColumnDataAccessor* seq_column = nullptr;
+ size_t segment_pos;
for (auto cid : including_cids) {
+ // here we get segment column row num before append data.
+ segment_pos = _column_writers[cid]->get_next_rowid();
Review Comment:
`segment_pos` is never updated after initialized in each loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
