xinyiZzz commented on code in PR #21522:
URL: https://github.com/apache/doris/pull/21522#discussion_r1253309280


##########
be/src/olap/segment_loader.h:
##########
@@ -53,7 +54,7 @@ class BetaRowset;
 //
 // Make sure that cache_handle is valid during the segment usage period.
 using BetaRowsetSharedPtr = std::shared_ptr<BetaRowset>;
-class SegmentLoader {
+class SegmentLoader : public LRUCachePolicy {

Review Comment:
   其实 SegmentLoader 应该改名叫 SegmentCache,SegmentLoader就是cache
   我那会想改来着,不过 Ctrl F SegmentLoader 的地方太多了。。。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to