yiguolei commented on code in PR #21522:
URL: https://github.com/apache/doris/pull/21522#discussion_r1253283673
##########
be/src/olap/segment_loader.h:
##########
@@ -53,7 +54,7 @@ class BetaRowset;
//
// Make sure that cache_handle is valid during the segment usage period.
using BetaRowsetSharedPtr = std::shared_ptr<BetaRowset>;
-class SegmentLoader {
+class SegmentLoader : public LRUCachePolicy {
Review Comment:
这个这么继承感觉不好，不如封装一个SegmentCache ： public LRUCachePolicy， 然后 segment loader 中引用
SegmentCache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
