yiguolei commented on code in PR #21522:
URL: https://github.com/apache/doris/pull/21522#discussion_r1253314001
##########
be/src/olap/segment_loader.h:
##########
@@ -53,7 +54,7 @@ class BetaRowset;
//
// Make sure that cache_handle is valid during the segment usage period.
using BetaRowsetSharedPtr = std::shared_ptr<BetaRowset>;
-class SegmentLoader {
+class SegmentLoader : public LRUCachePolicy {
Review Comment:
应该不能。 Cache 一般都是被动的push。 比如segment loader
中他还有怎么加载segment的逻辑，加载完才放到cache里，cache 只有简单的put，get
接口，没有具体怎么加载segment的逻辑，而这些逻辑是在segment loader 中的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
