[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4055: [Doris On ES] Add docvalue limitation for doc_values scan and enable doc_values scan default

[GitBox]

wuyunfeng commented on a change in pull request #4055:
URL: https://github.com/apache/incubator-doris/pull/4055#discussion_r451991400



##########
File path: fe/src/main/java/org/apache/doris/catalog/EsTable.java
##########
@@ -194,6 +219,17 @@ private void validate(Map<String, String> properties) 
throws DdlException {
                         + " but value is " + transport);
             }
         }
+
+        if (properties.containsKey(MAX_DOCVALUE_FIELDS)) {
+            try {
+                maxDocValueFields = 
Integer.parseInt(properties.get(MAX_DOCVALUE_FIELDS).trim());
+                if (maxDocValueFields < 1) {
+                    maxDocValueFields = 1;

Review comment:
       可以设置为0，不过控制开关的话还是用上面那个？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org