[GitHub] [incubator-doris] blackfox1983 commented on a change in pull request #4055: [Doris On ES] Add docvalue limitation for doc_values scan and enable doc_values scan default

[GitBox]

blackfox1983 commented on a change in pull request #4055:
URL: https://github.com/apache/incubator-doris/pull/4055#discussion_r451984363



##########
File path: fe/src/main/java/org/apache/doris/planner/EsScanNode.java
##########
@@ -109,6 +110,34 @@ public void finalize(Analyzer analyzer) throws 
UserException {
         isFinalized = true;
     }
 
+    /**
+     * return whether can use the doc_values scan
+     * 0 and 1 are returned to facilitate Doris BE processing

Review comment:
       我不太确定 fe通过thrift传递给be的参数是否支持bool。这个地方读起来bool更直观。
   否则我得带着c++的思维去理解。（1是true，0是false）




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org