[GitHub] [incubator-doris] blackfox1983 commented on a change in pull request #4055: [Doris On ES] Add docvalue limitation for doc_values scan and enable doc_values scan default

[GitBox]

blackfox1983 commented on a change in pull request #4055:
URL: https://github.com/apache/incubator-doris/pull/4055#discussion_r451983749



##########
File path: fe/src/main/java/org/apache/doris/catalog/EsTable.java
##########
@@ -294,6 +331,13 @@ public void readFields(DataInput in) throws IOException {
             } else {
                 enableKeywordSniff = true;
             }
+            if (tableContext.containsKey("maxDocValueFields")) {
+                try {
+                    maxDocValueFields = 
Integer.parseInt(tableContext.get("maxDocValueFields"));
+                } catch (Exception e) {
+                    maxDocValueFields = 30;

Review comment:
       这个地方是不是可以使用定义的值？DEFAULT_MAX_DOC_VALUS_FILEDS




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org