mrhhsg commented on code in PR #19973: URL: https://github.com/apache/doris/pull/19973#discussion_r1208027343
########## be/src/util/bitmap_value.h: ########## @@ -1888,6 +2414,17 @@ class BitmapValue { } break; } + case SET: { + std::vector<uint64_t> values; + for (auto v : _set) { + values.emplace_back(v); + } + std::sort(values.begin(), values.end()); Review Comment: Yes, `std::set` is good enough when the elements' count is negligible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org