cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205130190
##########
be/src/util/bitmap_value.h:
##########
@@ -1742,17 +2186,43 @@ class BitmapValue {
return _sv;
case BITMAP:
return _bitmap->maximum();
+ case SET:
+ return _max_in_set();
default:
return 0;
}
}
uint64_t max(bool* empty) const {
- return min_or_max(empty, [&]() { return _bitmap->maximum(); });
+ return min_or_max(empty, [&]() { return maximum(); });
}
uint64_t min(bool* empty) const {
- return min_or_max(empty, [&]() { return _bitmap->minimum(); });
+ return min_or_max(empty, [&]() { return minimum(); });
+ }
+
+ uint64_t _min_in_set() const {
+ uint64_t result = std::numeric_limits<uint64_t>::max();
+ if (_type == SET) {
Review Comment:
```suggestion
DCHECK(_type == SET);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
