cambyzju commented on code in PR #19973:
URL: https://github.com/apache/doris/pull/19973#discussion_r1205215021
##########
be/src/util/bitmap_value.h:
##########
@@ -1888,6 +2414,17 @@ class BitmapValue {
}
break;
}
+ case SET: {
+ std::vector<uint64_t> values;
+ for (auto v : _set) {
+ values.emplace_back(v);
+ }
+ std::sort(values.begin(), values.end());
Review Comment:
std::set or phmap::flat_hash_set is better for at most 32 elements?
if std::set is not too bad, we can avoid copy to array and sort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
